Pass additional args to callable option cors_allowed_origins#398
Merged
miguelgrinberg merged 2 commits intomiguelgrinberg:mainfrom Apr 12, 2025
Merged
Pass additional args to callable option cors_allowed_origins#398miguelgrinberg merged 2 commits intomiguelgrinberg:mainfrom
miguelgrinberg merged 2 commits intomiguelgrinberg:mainfrom
Conversation
If option cors_allowed_origins is callable, pass additional args for default_origins and environ to it. Use try-except to still allow usage of a callback without these additional args.
Owner
|
Thanks! I have simplified the CORS allowed hosts calculation a bit and changed your proposal call signature to include only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If option cors_allowed_origins is callable, pass additional args for default_origins and environ to it. Use try-except to still allow usage of a callback without these additional args.
Background:
For our project, we need to dynamically check for origins, which are allowed additionally to the default ones (especially the same origin).
The try-except is just a proposal to avoid a breaking change.